Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] send_transaction_multi no longer sending #17751

Closed
cmmarslender opened this issue Mar 20, 2024 · 0 comments · Fixed by #17752
Closed

[Bug] send_transaction_multi no longer sending #17751

cmmarslender opened this issue Mar 20, 2024 · 0 comments · Fixed by #17752
Labels
bug Something isn't working

Comments

@cmmarslender
Copy link
Contributor

cmmarslender commented Mar 20, 2024

What happened?

Calling send_transaction_multi doesn't result in the transaction actually being sent. I get back success: true and a TX ID, but wallet state never seems to change, as if TX wasn't actually pushed.

I believe #17436 is the PR that introduced the breaking change. If we intend to keep the changes as they are now, we probably need to make sure we call out that its a breaking change, though I'm not entirely sure that an RPC call that has "send" in the name makes sense to default to not actually sending

Normal send_transaction has this (@tx_endpoint(push=True)): https://github.com/Chia-Network/chia-blockchain/blob/main/chia/rpc/wallet_rpc_api.py#L1125

Maybe that should also exist here? https://github.com/Chia-Network/chia-blockchain/blob/main/chia/rpc/wallet_rpc_api.py#L1173

Version

latest main

What platform are you using?

Linux

What ui mode are you using?

CLI

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant