Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one single SE API filter globally #4145

Closed
iBug opened this issue Jul 4, 2020 · 3 comments
Closed

Use one single SE API filter globally #4145

iBug opened this issue Jul 4, 2020 · 3 comments
Assignees
@makyen
Labels
status: confirmed Confirmed as something that needs working on. type: refactor

Comments

@iBug
Copy link
Member

iBug commented Jul 4, 2020

Originally mentioned by @makyen here: #4074 (review)

We have several places where an API filter is specified directly, and in most of these cases what we want is almost identical. Aggregating these into one filter in GlobalVars is a better idea for reasons of simplicity and maintainability.
@iBug iBug mentioned this issue Jul 4, 2020
Closed
@stale stale bot added the status: stale label Aug 4, 2020
@user12986714
Copy link
Contributor

(antifreeze)

@stale stale bot removed the status: stale label Aug 4, 2020
@stale stale bot added the status: stale label Sep 4, 2020
@stale
Copy link

stale bot commented Sep 5, 2020

This issue has been closed because it has had no recent activity. If this is still important, please add another comment and find someone with write permissions to reopen the issue. Thank you for your contributions.

@stale stale bot closed this as completed Sep 5, 2020
@makyen makyen reopened this Sep 5, 2020
@stale stale bot removed the status: stale label Sep 5, 2020
@makyen makyen added the status: confirmed Confirmed as something that needs working on. label Sep 5, 2020
@makyen makyen self-assigned this Apr 27, 2022
@makyen makyen mentioned this issue Apr 27, 2022
Open
@makyen
Copy link
Contributor

makyen commented Dec 25, 2024

This was done in PR #7395.

@makyen makyen closed this as completed Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@makyen makyen

Labels
status: confirmed Confirmed as something that needs working on. type: refactor
Milestone
No milestone
Development

No branches or pull requests
3 participants
@makyen @iBug @user12986714