Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update light client proof logic to root next sync committee in attested header #4426

Closed
EchoAlice opened this issue Aug 16, 2022 · 0 comments · Fixed by #4478
Closed

Update light client proof logic to root next sync committee in attested header #4426

EchoAlice opened this issue Aug 16, 2022 · 0 comments · Fixed by #4478
Assignees
@dadepo
Labels
scope-light-clients All issues regarding light client development.

Comments

@EchoAlice
Copy link

Describe the bug
Light client proofs for update's next sync committee hash against the update's finalized header state instead of its attested header state. This was fine before Etan's updates to the spec, but aren't allowed now.

Reference:
ethereum/consensus-specs@c4dbd24

Expected behavior
When requesting light client updates, update.next_sync_committee hashed with update.next_sync_committee_branch == update.attested_header.state_root
@philknows philknows added the scope-light-clients All issues regarding light client development. label Aug 17, 2022
@dadepo dadepo self-assigned this Aug 17, 2022
@dadepo dadepo mentioned this issue Aug 25, 2022
Merged
3 tasks
@dadepo dadepo moved this from Todo to In Progress in Lodestar Sprint Planning Sep 2, 2022
Repository owner moved this from In Progress to Done in Lodestar Sprint Planning Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dadepo dadepo

Labels
scope-light-clients All issues regarding light client development.
Projects
No open projects
Lodestar Sprint Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating light client proof logic to root next sync committee in attested header ChainSafe/lodestar
3 participants
@dadepo @philknows @EchoAlice