Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept interfaces, return structs #2088

Closed
kishansagathiya opened this issue Nov 30, 2021 · 1 comment · Fixed by #2142
Closed

Accept interfaces, return structs #2088

kishansagathiya opened this issue Nov 30, 2021 · 1 comment · Fixed by #2142
Assignees
@kishansagathiya

Comments

@kishansagathiya
Copy link
Contributor

Task summary

  • I have been returning Message interface instead of individual structs. I like the idea that all messages are just the same and not having to export a whole bunch of structs. But there is a lot of literature for returning structs. This is mostly a reminder to me to read those and change all instances where I have returned Message, if needed.

Specification reference

Other information and links
@qdm12
Copy link
Contributor

qdm12 commented Dec 23, 2021

Maybe you can add linter ireturn and do it across the entire codebase 🤔

@kishansagathiya kishansagathiya mentioned this issue Jan 5, 2022
Merged
@qdm12 qdm12 mentioned this issue Jan 7, 2022
Open
@qdm12 qdm12 mentioned this issue Oct 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kishansagathiya kishansagathiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(dot/telemetry): Return concrete types ChainSafe/gossamer
3 participants
@danforbes @kishansagathiya @qdm12