New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dot/network: update notifications protocol to track specific stream w/ established handshake #1524

Closed

noot opened this issue Apr 13, 2021 · 0 comments · Fixed by #1545

Assignees

Contributor

noot commented Apr 13, 2021

Task summary

currently, a stream is established via handshake, however when messages are sent out it doesn't necessarily send it over the established stream
we should track established streams and use them for pushing notifications messages
this can be done potentially by storing the stream inside a peer's handshakeData or by tagging the libp2p stream itself https://pkg.go.dev/github.com/libp2p/go-libp2p-core/network#Stat using Stat.Extra

The text was updated successfully, but these errors were encountered:

noot added network labels

dutterbutter removed the Status: Needs Triage label

dutterbutter assigned arijitAD

dutterbutter added the approved label

arijitAD mentioned this issue

fix(dot/network): Fix notification handshake and reuse stream. #1545

Merged

noot closed this as completed in #1545

noot mentioned this issue

fix(dot/network): split stored streams and handshakeData into inbound and outbound #1553

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment