From 6e260642448c16205ab79fba72f539bc9d2b9a00 Mon Sep 17 00:00:00 2001
From: Quentin McGaw <quentin.mcgaw@gmail.com>
Date: Tue, 24 Jan 2023 12:58:58 +0000
Subject: [PATCH] Use pointer receivers for some types: - Trie `Node`'s `Copy`
 method - pprof `Settings`'s `String` method Keep value receivers for some
 types: - Keep value receivers for VDTs - `common.Hash`,
 `transaction.priorityQueue`

---
 internal/pprof/settings.go     | 4 ++--
 internal/trie/node/copy.go     | 2 +-
 pkg/scale/varying_data_type.go | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/internal/pprof/settings.go b/internal/pprof/settings.go
index 00dca7e920..fd676f672d 100644
--- a/internal/pprof/settings.go
+++ b/internal/pprof/settings.go
@@ -18,13 +18,13 @@ type Settings struct {
 	MutexProfileRate int
 }
 
-func (s *Settings) setDefaults() { //skipcq: GO-W1029
+func (s *Settings) setDefaults() {
 	if s.ListeningAddress == "" {
 		s.ListeningAddress = "localhost:6060"
 	}
 }
 
-func (s Settings) String() string { //skipcq: GO-W1029
+func (s *Settings) String() string {
 	return fmt.Sprintf(
 		"listening on %s and setting block profile rate to %d, mutex profile rate to %d",
 		s.ListeningAddress, s.BlockProfileRate, s.MutexProfileRate)
diff --git a/internal/trie/node/copy.go b/internal/trie/node/copy.go
index e83553fdef..7471e5c982 100644
--- a/internal/trie/node/copy.go
+++ b/internal/trie/node/copy.go
@@ -53,7 +53,7 @@ type CopySettings struct {
 // Copy deep copies the node.
 // Setting copyChildren to true will deep copy
 // children as well.
-func (n *Node) Copy(settings CopySettings) *Node { //skipcq: GO-W1029
+func (n *Node) Copy(settings CopySettings) *Node {
 	cpy := &Node{
 		Dirty:       n.Dirty,
 		Generation:  n.Generation,
diff --git a/pkg/scale/varying_data_type.go b/pkg/scale/varying_data_type.go
index 3e6db4414f..c5b9be40bb 100644
--- a/pkg/scale/varying_data_type.go
+++ b/pkg/scale/varying_data_type.go
@@ -83,7 +83,7 @@ func (vdt *VaryingDataType) Value() (VaryingDataTypeValue, error) { //skipcq: GO
 	return vdt.value, nil
 }
 
-func (vdt VaryingDataType) String() string { //skipcq: GO-W1029
+func (vdt *VaryingDataType) String() string { //skipcq: GO-W1029
 	if vdt.value == nil {
 		return "VaryingDataType(nil)"
 	}