This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
fix: refactor deprecated snap_getBip44Entropy_* with snap_getBip44Entropy
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://filsnap-showcase-pr-223.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ccdii81a6gdue2j6pvng. |
irubido
previously approved these changes
Sep 9, 2022
…' into beroburny/fix-get-bip-44-entropy
Lykhoyda
approved these changes
Nov 2, 2022
mpetrunic
reviewed
Nov 2, 2022
There was a problem hiding this comment.
@BeroBurny this is breaking change and should be released as major version. Be more mindful with semver versioning.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #222
waiting for metamask 10.19 release