[ENG-4255] update to public true on ham just the objects that were public before were spammed

[mkovalua]

Purpose

When a user is is designated as Spam, and then confirmed as Ham, sometimes their preprints remain set to private.
It is needed to update to public true on ham just the objects that were public before were spammed.

Changes

It is needed to was_public parameter from the latest spammed log that was after public/private changings

preprint

Screen.Recording.2025-02-11.at.16.22.56.1.mp4

registration

Screen.Recording.2025-02-11.at.20.23.09.mp4

node (branched embargoed registration from project)

Screen.Recording.2025-02-13.at.00.05.32.1.mov

QA Notes

Please make verification statements inspired by your code and what your code touches.

• Verify
• Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-4255

[brianjgeiger]

Could you add some tests please, both to catch the new functionality and, if they don't exist, to make sure you don't accidentally make something public that shouldn't be.

[brianjgeiger]

There are some additional test cases that you should add. All of them are for registrations, and they are all for registrations that are based on a project.

1. Project starts as public, registration is embargoed, should not be made public.
2. Project starts as private, registration is embargoed, should not be made public.
3. Project starts as private, project is made public, registration is embargoed, should not be made public.
4. Project starts as public, project is made private, registration is embargoed, should not be made public.

5-8 should be 1-4 except that the registration is public and always should be made public.

Invalid review

[Johnetordoff]

@mkovalua can you also write test cases that test that the task scripts/approve_registrations.py runs correctly for registrations that are in spam or hammed state. That celery task has had issues dealing with registration state errors.

[brianjgeiger]

@mkovalua Please merge the latest CenterForOpenScience:feature/b-and-i-25-01 branch into your PR so that we can get tests to run.

[brianjgeiger]

@Johnetordoff Is this now testing what you wanted it to test?

[Johnetordoff]

@brianjgeiger yay it's called approve_registrations_runner in the tests, it might have been better to run as a celery task (like it is on Prod) in these tests, but this still covers any problems with the business logic. But LGTM.