Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-5158] Add node addons acceptance tests #2264

Merged
merged 2 commits into from
Jul 15, 2024
Merged

[ENG-5158] Add node addons acceptance tests #2264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3816cf
Add node addons acceptance tests
futa-ikeda Jul 4, 2024
5dd5311
Skip problematic test
futa-ikeda Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions app/guid-node/addons/index/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
<div local-class='account-select'>
<label>
<Input
data-test-existing-authorized-accounts-input
name='account-select'
@value={{account.id}}
@type='radio'
Expand Down Expand Up @@ -163,7 +164,10 @@
<h4>{{t 'addons.list.connected-locations'}}</h4>
</div>
{{#each provider.configuredAddons as |configuredAddon|}}
<div local-class='configured-addon-display-name'>
<div
data-test-configured-addon-name
local-class='configured-addon-display-name'
>
{{configuredAddon.displayName}}
<span local-class='float-right'>
<Button
Expand All @@ -189,7 +193,10 @@
</Button>
</span>
</div>
<div local-class='configured-addon-root-folder'>
<div
data-test-configured-addon-root-folder
local-class='configured-addon-root-folder'
>
{{#if configuredAddon.rootFolder}}
{{configuredAddon.rootFolder}}
{{else}}
Expand Down Expand Up @@ -277,8 +284,18 @@
local-class='tab-list'
as |tablist|
>
<tablist.tab data-analytics-name='Select All Addons tab'>{{t 'addons.list.all-addons'}}</tablist.tab>
<tablist.tab data-analytics-name='Select Connected Accounts tab'>{{t 'addons.list.connected-accounts'}}</tablist.tab>
<tablist.tab
data-test-addons-tab-all-addons
data-analytics-name='Select All Addons tab'
>
{{t 'addons.list.all-addons'}}
</tablist.tab>
<tablist.tab
data-test-addons-tab-connected-accounts
data-analytics-name='Select Connected Accounts tab'
>
{{t 'addons.list.connected-accounts'}}
</tablist.tab>
</tab.tabList>
<tab.tabPanel
data-test-all-addons-tab
Expand Down Expand Up @@ -349,7 +366,10 @@
</Button>
{{/each}}
</div>
<div local-class='addon-cards-wrapper'>
<div
data-test-configured-provider-list
local-class='addon-cards-wrapper'
>
{{#if manager.currentListIsLoading}}
<LoadingIndicator @dark={{true}} />
{{else}}
Expand Down
2 changes: 1 addition & 1 deletion lib/osf-components/addon/components/addons-service/addon-account-setup/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ interface InputFieldObject {
labelText: string;
inputType: string;
inputPlaceholder: string;
inputValue: string;
inputValue?: string;
autocomplete?: string;
postText?: string;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/osf-components/addon/components/addons-service/addon-account-setup/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
autocomplete={{field.autocomplete}}
@type={{field.inputType}}
@value={{field.inputValue}}
{{on 'keyup' @onInput}}
{{on 'input' @onInput}}
/>
{{/let}}
{{/each}}
Expand Down
2 changes: 1 addition & 1 deletion lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default class ConfiguredAddonEdit extends Component<Args> {
};

get invalidDisplayName() {
return this.displayName.trim().length === 0;
return this.displayName?.trim().length === 0;
}

get folderChanged() {
Expand Down
Loading
Loading