Feature/cedar integration #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* prototype CEEE * CR followup * fix args names
…integration (#2091) * Added the cedar metadata template model * Added the new models for cedar-metadata-template and record * Fixed some linting issues * Added the adapters and serializers for cedar metadata template and record * Fixed some typos and ignorance with serializers, api-contracts, etc * Fixed the namespace * Fixed the all the relationships
…2093) * Updates to convert the currect guid-metadata to tab based * Added the tabbing system to the metadata page * Initial commit for geting the mirage serializers to work for cedar-metadata-records * Updates from PR comments
* Added the initial metadata-detail component * Added some more touches to the detail template * Removed unnecessary mobile styling and actually the component. * Much cleaner look and feel for the read-only view * Added more randomness
…the initial editor post on save
…o work for create and patch
…ming of variables
* Moved the "Select a different template" button * Fixed a typo on including a component * Added the async on route transition * Updates to disable adding a duplicate record * Added select disable functionality to registries * Finished the disable feature for files and fixed some other nuisances * Added sorting and moved the selected tab to the first
* Enabled the embedding of templates on cedar records * Fixed a discepancy on the tab views * More one fix for consistency
Pull Request Test Coverage Report for Build 8007223254Details
💛 - Coveralls |
futa-ikeda
previously approved these changes
Feb 13, 2024
Comment on lines
+4
to
+5
| border-top: 2px solid #ddd; | ||
| border-top: 2px solid rgb(221, 221, 221); |
There was a problem hiding this comment.
Suggested change
| border-top: 2px solid #ddd; | |
| border-top: 2px solid rgb(221, 221, 221); | |
| border-top: 2px solid $color-border-gray; |
futa-ikeda
reviewed
Feb 13, 2024
| @attr('object') metadata!: any; | ||
| @attr('boolean') isPublished!: boolean; | ||
|
|
||
| @tracked templateName!: string; |
There was a problem hiding this comment.
Note: Thought this was unused and leftover, but this is used as an alias for the template.name in the code.
brianjgeiger
previously approved these changes
Feb 13, 2024
* fixes * fix test errors
…tion (#2150) * upgrade cee version. listen to more events to trigger validation * change to pointerover
brianjgeiger
approved these changes
Feb 22, 2024
bp-cos
approved these changes
Feb 22, 2024
futa-ikeda
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Merge
feature/cedar-integrationintodevelop.Summary of Changes
Screenshot(s)
Side Effects
QA Notes