CR feedback

CenterForOpenScience · Dec 19, 2023 · d30e51a · d30e51a
1 parent 3c0d848
commit d30e51a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 13 deletions.
diff --git a/app/guid-node/addons/route.ts b/app/guid-node/addons/route.ts
@@ -1,10 +1,6 @@
 import Route from '@ember/routing/route';
-import { inject as service } from '@ember/service';
-import Store from '@ember-data/store';
 
 export default class GuidNodeAddons extends Route {
-    @service store: Store;
-
     async model() {
         return await this.modelFor('guid-node').taskInstance;
     }

diff --git a/lib/osf-components/addon/components/addon-card/component.ts b/lib/osf-components/addon/components/addon-card/component.ts
@@ -11,11 +11,10 @@ interface Args {
     manager: AddonsServiceManagerComponent;
 }
 
-const addonLogoMap: Record<string, string> = {
+const legacyAddonLogoMap: Record<string, string> = {
     aws: '/assets/images/addons/logos/aws.png',
     bitbucket: '/assets/images/addons/logos/bitbucket.png',
     boa: '/assets/images/addons/logos/boa_color.png',
-    box: '/assets/images/addons/logos/box.png',
     dataverse: '/assets/images/addons/logos/dataverse.png',
     dropbox: '/assets/images/addons/logos/dropbox.png',
     figshare: '/assets/images/addons/logos/figshare.png',
@@ -31,11 +30,6 @@ const addonLogoMap: Record<string, string> = {
 export default class AddonsCardComponent extends Component<Args> {
     @tracked deleteModalOpen = false;
 
-    @action
-    toggleDeleteModal() {
-        this.deleteModalOpen = !this.deleteModalOpen;
-    }
-
     @action
     closeDeleteModal() {
         this.deleteModalOpen = false;
@@ -48,7 +42,11 @@ export default class AddonsCardComponent extends Component<Args> {
     }
 
     get assetLogo() {
-        return addonLogoMap[this.args.addon.provider.id];
+        if (this.args.addon instanceof LegacyProvider) {
+            return legacyAddonLogoMap[this.args.addon.provider.id];
+        } else {
+            return this.args.addon.provider.iconUri;
+        }
     }
 
     get addonIsConfigured() {

diff --git a/lib/osf-components/addon/components/addon-card/template.hbs b/lib/osf-components/addon/components/addon-card/template.hbs
@@ -31,7 +31,7 @@
                 data-test-addon-card-disable
                 data-analytics-name='Disable'
                 local-class='disable'
-                {{on 'click' this.toggleDeleteModal}}
+                {{on 'click' (action (mut this.toggleDeleteModal) true)}}
             >
                 {{t 'osf-components.addon-card.disable'}}
             </Button>

diff --git a/public/assets/images/addons/logos/box.png b/public/assets/images/addons/logos/box.png