Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify schema for marker relations #66

Open
dosumis opened this issue Dec 12, 2024 · 2 comments
Open

Clarify schema for marker relations #66

dosumis opened this issue Dec 12, 2024 · 2 comments
Assignees

Comments

@dosumis
Copy link
Contributor

dosumis commented Dec 12, 2024

we have marker relations 2 right now:

Proposed solution: Reserve former for single genes, use latter for combos?

Also - I think these should really be Annotation Properties in OWL as ObjectProperty restrictions are inherited down the class hierarchy. Markers are not. Can we get them changed in RO?

@dillerm
Copy link
Collaborator

dillerm commented Dec 19, 2024

I reviewed this with @scheuerm and the main argument we have for keeping the transcripts as nodes is because the genes they're associated with are important connection points to drugs and diseases, which may be more easily handled if the transcripts are actual graph node. We also discussed the concern that you raised about inheritance and aren't too concerned about that being a problem, although I am curious about any examples that should give us concern.

@dosumis
Copy link
Contributor Author

dosumis commented Dec 20, 2024

They will still be nodes in the graph. Using an AP to link two nodes (classes or individuals) just ensures we don't get unwanted inferences of markers down the graph/class-hierarchy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants