Feature/cspr v50 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfeldman
commented
Oct 29, 2020
| string_type = {"type": ["string", "null"]} | ||
| property_schema["anyOf"] = [date_type, string_type] | ||
| property_schema["format"] = "date-time" | ||
| property_schema["type"] = ["string", "null"] |
There was a problem hiding this comment.
anyOf is not supported in the redshift target. Using anyOf leads to the redshift target creating multiple columns in redshift, one for the string type and one for the date time type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Making v50 work. The point of this pull request is to show the work involved to decide if we want to use it.