From e8ff31100cbaa77f12b9c1cf94d3d61d950405fd Mon Sep 17 00:00:00 2001 From: Charly Date: Mon, 31 Oct 2022 11:31:19 +0100 Subject: [PATCH] fix: rm bech32 check from owner address on ICA controller msgs RegisterInterchainAccount and SendTx (#2601) * rm validate basic owner address check --- .../controller/types/msgs.go | 8 -------- .../controller/types/msgs_test.go | 14 -------------- 2 files changed, 22 deletions(-) diff --git a/modules/apps/27-interchain-accounts/controller/types/msgs.go b/modules/apps/27-interchain-accounts/controller/types/msgs.go index 1096c62e9d7..9f9f0434195 100644 --- a/modules/apps/27-interchain-accounts/controller/types/msgs.go +++ b/modules/apps/27-interchain-accounts/controller/types/msgs.go @@ -31,10 +31,6 @@ func (msg MsgRegisterInterchainAccount) ValidateBasic() error { return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, "owner address cannot be empty") } - if _, err := sdk.AccAddressFromBech32(msg.Owner); err != nil { - return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "failed to parse owner address: %s", msg.Owner) - } - return nil } @@ -68,10 +64,6 @@ func (msg MsgSendTx) ValidateBasic() error { return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, "owner address cannot be empty") } - if _, err := sdk.AccAddressFromBech32(msg.Owner); err != nil { - return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "failed to parse owner address: %s", msg.Owner) - } - if err := msg.PacketData.ValidateBasic(); err != nil { return sdkerrors.Wrap(err, "invalid interchain account packet data") } diff --git a/modules/apps/27-interchain-accounts/controller/types/msgs_test.go b/modules/apps/27-interchain-accounts/controller/types/msgs_test.go index 6e6487c0b66..3f8ccb9d881 100644 --- a/modules/apps/27-interchain-accounts/controller/types/msgs_test.go +++ b/modules/apps/27-interchain-accounts/controller/types/msgs_test.go @@ -62,13 +62,6 @@ func TestMsgRegisterInterchainAccountValidateBasic(t *testing.T) { }, false, }, - { - "owner address is invalid", - func() { - msg.Owner = "invalid_address" - }, - false, - }, } for i, tc := range testCases { @@ -125,13 +118,6 @@ func TestMsgSendTxValidateBasic(t *testing.T) { }, false, }, - { - "owner address is invalid", - func() { - msg.Owner = "invalid_address" - }, - false, - }, { "relative timeout is not set", func() {