-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import button does nothing #142
Comments
It currently doesn't follow symlinks. I was afraid of infinite recursion when I wrote the import routine, but I guess I should work on something more robust that will follow them but track if it has followed that symlink before. |
On 2021-04-04 12:09:45, CarVac wrote:
It currently doesn't follow symlinks.
I was afraid of infinite recursion when I wrote the import routine, but I guess I should work on something more robust that will follow them but track if it has followed that symlink before.
I would argue that people who create infinite recursions get what they
desserve. Maybe an option flag?
…--
Perl is "some assembly required". Python is "batteries included". PHP
is "kitchen sink, but it’s from Canada and both faucets are labeled C".
- Alex Munroe, PHP: a fractal of bad design
|
Maybe I'll just set a recursion depth limit of something reasonable, like 20. Would that be enough for your use case? Are all subdirectories in git-annex symbolic links? |
On 2021-04-05 15:25:34, CarVac wrote:
Maybe I'll just set a recursion depth limit of something reasonable, like 20. Would that be enough for your use case? Are all subdirectories in git-annex symbolic links?
Only the files are symlinks, not directories.
|
Ah, this will take another round of tweaking then (I made it follow folder symlinks to a limited recursion depth). |
On 2021-04-06 06:08:50, CarVac wrote:
Ah, this will take another round of tweaking then (I made it follow folder symlinks to a limited recursion depth).
I would really not worry about following symlinks at all,
personnally. Just follow them: if it breaks, it's garbage in, garbage
out.
…--
"Faith" means not wanting to know what is true.
- Friedrich Nietzshe
|
Could you test the v0.11.2rc1 AppImage from here? https://discuss.pixls.us/t/filmulator-nightly-builds-now-for-windows-and-linux/12838 Also, I believe it should have worked already if you imported individual files instead of a whole directory. |
i'm a little hesitant in running arbitrary code without a sandbox from the web... it's why i like using the flathub thing. ;) could the RCs be pushed to flathub as well? |
You can |
I tried to import pictures from
~/Photos/2021
in my home directory, and the "import" button did nothing whatsoever. Maybe it's because the files are symlinked (managed by git-annex) or under some sub-sub directory? directory structure is like~/Photos/YYYY/MM/DD/NAME/
...installed through flathub.
thanks!
The text was updated successfully, but these errors were encountered: