Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import button does nothing #142

Open
anarcat opened this issue Apr 4, 2021 · 9 comments
Open

import button does nothing #142

anarcat opened this issue Apr 4, 2021 · 9 comments

Comments

@anarcat
Copy link

anarcat commented Apr 4, 2021

I tried to import pictures from ~/Photos/2021 in my home directory, and the "import" button did nothing whatsoever. Maybe it's because the files are symlinked (managed by git-annex) or under some sub-sub directory? directory structure is like ~/Photos/YYYY/MM/DD/NAME/...

installed through flathub.

thanks!

@CarVac
Copy link
Owner

CarVac commented Apr 4, 2021

It currently doesn't follow symlinks.

I was afraid of infinite recursion when I wrote the import routine, but I guess I should work on something more robust that will follow them but track if it has followed that symlink before.

@anarcat
Copy link
Author

anarcat commented Apr 4, 2021 via email

@CarVac
Copy link
Owner

CarVac commented Apr 5, 2021

Maybe I'll just set a recursion depth limit of something reasonable, like 20. Would that be enough for your use case? Are all subdirectories in git-annex symbolic links?

@anarcat
Copy link
Author

anarcat commented Apr 6, 2021 via email

@CarVac
Copy link
Owner

CarVac commented Apr 6, 2021

Ah, this will take another round of tweaking then (I made it follow folder symlinks to a limited recursion depth).

@anarcat
Copy link
Author

anarcat commented Apr 6, 2021 via email

@CarVac
Copy link
Owner

CarVac commented Apr 8, 2021

Could you test the v0.11.2rc1 AppImage from here?

https://discuss.pixls.us/t/filmulator-nightly-builds-now-for-windows-and-linux/12838

Also, I believe it should have worked already if you imported individual files instead of a whole directory.

@anarcat
Copy link
Author

anarcat commented Apr 8, 2021

Could you test the v0.11.2rc1 AppImage from here?

i'm a little hesitant in running arbitrary code without a sandbox from the web... it's why i like using the flathub thing. ;) could the RCs be pushed to flathub as well?

@CarVac
Copy link
Owner

CarVac commented Apr 8, 2021

You can firejail appimages if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants