Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigInt support? #11

Open
CanadaHonk opened this issue Oct 10, 2024 · 6 comments
Open

BigInt support? #11

CanadaHonk opened this issue Oct 10, 2024 · 6 comments

Comments

@CanadaHonk
Copy link
Owner

needs more discussion. cc @ljharb

@ljharb
Copy link

ljharb commented Oct 10, 2024

I think it would be a great potential change to make (only needed before stage 2.7) to allow 2-3 BigInts, instead of only 2-3 Numbers.

@Richienb
Copy link
Collaborator

Should the change be made here, or in a separate proposal along with Math.min and Math.max?

@hax
Copy link

hax commented Oct 12, 2024

Also Decimal128 (stage 1) ?

@bakkot
Copy link

bakkot commented Jan 5, 2025

At least some of the Math methods (e.g. sumPrecise) cannot be made to work with BigInts, so none of them should.

@ljharb
Copy link

ljharb commented Jan 5, 2025

If that was a reasonable consequence of that proposal advancing, then that should have been discussed prior to it reaching stage 3, as part of the “cross-cutting concerns” requirement. I don’t see any reason that it’s all or nothing for Math BigInt support.

@bakkot
Copy link

bakkot commented Jan 6, 2025

I mentioned several times that sumPrecise did not support BigInt inputs. That this implies other Math methods should not support BigInt inputs is my opinion only (which I've also stated several times, such as in the thread linked above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants