Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specimen related fields in Sample Registration #3

Open
mshadbolt opened this issue Oct 24, 2023 · 2 comments
Open

Specimen related fields in Sample Registration #3

mshadbolt opened this issue Oct 24, 2023 · 2 comments

Comments

@mshadbolt
Copy link

mshadbolt commented Oct 24, 2023

Several fields in the Sample Registration object seem that they would be more appropriate within the Specimen object, these are:

  • specimen_type
  • specimen_tissue_source
  • tumour_normal_designation

In addition, the specimen_type and tumour_normal_designation appear to contain overlapping information, it is unclear why both would be needed within one object.

See v2 google sheet: https://docs.google.com/spreadsheets/d/17Azd7dIORYIXk-czIEYJW9gNGgr6_IDmjRv1F20bEIU/edit#gid=0&range=B7

(edited to include comment below)

@kcranston
Copy link
Member

The same question holds for tumour_normal_designation which is under the Sample Registration schema but describes a Specimen.

@mshadbolt mshadbolt changed the title Location of specimen_type Location of Specimen related fields in Sample Registration Oct 26, 2023
@mshadbolt mshadbolt changed the title Location of Specimen related fields in Sample Registration Specimen related fields in Sample Registration Oct 26, 2023
@jmtnelson
Copy link

I thought we agreed to move these fields sometime ago. the specimen table is very awkward for the normal sample, there is essentially no field other than collection that pertain to the normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants