fix: fully escape string for usage in require call #272
+91
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use this loader in a project of mine and ran into some issues with certain file names I'm trying to load. Specifically, I have images whose file names contain single quotes
'
. This package would insert them into the generatedrequire
call as-is, leading to a parse error later on.As the package cannot control the file names it receives, it has to take care of fully escaping the string spliced into the generated module code. I have used the js-string-escape package for this, but the escape function is simple enough that it could also just be included in this package.