Skip to content

Commit

Permalink
Drop flake8 from dev container
Browse files Browse the repository at this point in the history
  • Loading branch information
InvincibleRMC committed Jul 9, 2024
1 parent f674aa5 commit ac3cb12
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/linux/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"workspaceFolder": "/home/rov/rov-25",
"customizations": {
"vscode" : {
"extensions": ["ms-python.flake8", "ms-azuretools.vscode-docker",
"extensions": ["ms-azuretools.vscode-docker",
"streetsidesoftware.code-spell-checker", "ms-python.isort",
"ms-python.mypy-type-checker"]
}
Expand Down
1 change: 0 additions & 1 deletion .devcontainer/linux_test_environment/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"customizations": {
"vscode": {
"extensions": [
"ms-python.flake8",
"ms-azuretools.vscode-docker",
"streetsidesoftware.code-spell-checker",
"ms-python.python",
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/macos/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"workspaceFolder": "/home/rov/rov-25",
"customizations": {
"vscode" : {
"extensions": ["ms-python.flake8", "ms-azuretools.vscode-docker",
"extensions": ["ms-azuretools.vscode-docker",
"streetsidesoftware.code-spell-checker", "ms-python.isort",
"ms-python.mypy-type-checker"]
}
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/windows/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"workspaceFolder": "/home/rov/rov-25",
"customizations": {
"vscode" : {
"extensions": ["ms-python.flake8", "ms-azuretools.vscode-docker",
"extensions": ["ms-azuretools.vscode-docker",
"streetsidesoftware.code-spell-checker", "ms-python.isort",
"ms-python.mypy-type-checker"]
}
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ git clone --recurse-submodules [email protected]:CWRUbotix/rov-25.git

If you've never contributed to a git repository before, you might receive an error message saying you don't have access. In that case visit [this tutorial](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/about-ssh) to set up SSH for local GitHub access.

After cloning the code, we need to set up our IDE: VSCode. If you already have it, great. Otherwise follow [this](https://code.visualstudio.com/download) tutorial. We recommend installing the mypy, flake8 and autoDocstring VSCode extensions. Our setting for autoDocstring are set to Numpy and auto docstring on new line.
After cloning the code, we need to set up our IDE: VSCode. If you already have it, great. Otherwise follow [this](https://code.visualstudio.com/download) tutorial. We recommend installing the mypy and autoDocstring VSCode extensions. Our setting for autoDocstring are set to Numpy and auto docstring on new line.

### Linux

Expand Down Expand Up @@ -160,7 +160,7 @@ In VSCode, press `F1` or `ctrl+shift+p` and enter `Tasks: Run Test Task` as anot

It runs the tests and pipes the output to the terminal. To test pi_main make sure to type your password into the terminal after running the above command.

If you install the flake8 and mypy extension they should help enforce the linters.
If you install the mypy extension they should help enforce the linters.

<!-- ### Automatic building for non-VSCode heathens
Expand Down

0 comments on commit ac3cb12

Please sign in to comment.