Fix file deletion when rotating and some bugfixes #718
Conversation
andreasbank
commented
Dec 5, 2024
andreasbank
commented
- Fix file deletion when rotating
- Correct mutexattr init
- Small code cleanup and improvements
- Properly terminate log messages
If there are more files than the configuration allows, delete them all, not just the last one
strncat() already searches for the null-term in src, making strlen() completely useless.
Without the newline character multiple logs get concatenated into a single log.
andreasbank
changed the title
| } | ||
| if (fsync(config->fd) != 0) { | ||
| if (errno != ENOSYS) { | ||
| dlt_vlog(LOG_ERR, "%s: failed to sync log file\n", __func__); |
There was a problem hiding this comment.
could you explain why it is only for non gzip?
There was a problem hiding this comment.
It is not only for gzip it is still for both cases, since I removed the gzip check.
Since fileno(config->gzlog) is config->fd and fileno(config->log) is also config->fd, then we can replace them both with a with a single fsync() call, regardless if config->gzip_compression is set or not.
The executed functions are exactly the same as before but the code looks a lot simpler.
There was a problem hiding this comment.
Check the huge refactor: #732
Thanks
There was a problem hiding this comment.
It is not only for gzip it is still for both cases, since I removed the gzip check.
Since fileno(config->gzlog) is config->fd and fileno(config->log) is also config->fd, then we can replace them both with a with a single fsync() call, regardless if config->gzip_compression is set or not. The executed functions are exactly the same as before but the code looks a lot simpler.
Not correct, gzlog is *gzFile, it could be handled like this:
if (config->gzlog && gzdirect(*config->gzlog)) {
int fd = fileno((FILE *)*config->gzlog);
if (fd != -1 && fsync(fd) != 0) {
if (errno != ENOSYS) {
dlt_vlog(LOG_ERR, "%s: failed to sync gzip log file\n", __func__);
|
Close by mistake, please check #732 for upcoming vers. |
