Fix compiler warnings related to strings #697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix string truncation and overflow warnings so the compiler flags stringop-overflow and stringop-truncation can be enabled. This shouldn't change any behaviour nor fix any bugs. It is just to be able to run the compiler with those flags so future bugs can be avoided. However I have added some extra checks for string lengths. Most changes is to avoid using strncat and instead use strcat. This doesn't make the code safer but removes the false safeness of using strncat wrongly.
src/console/dlt-passive-node-ctrl.c
Outdated
| @@ -113,7 +113,7 @@ void set_node_id(char *id) | |||
| exit(-1); | |||
| } | |||
| else { | |||
| strncpy(g_options.node_id, id, DLT_ID_SIZE); | |||
| strcpy(g_options.node_id, id); | |||
There was a problem hiding this comment.
This may overwrite the end of array g_options.node_id by one byte. node_id is not handled as a null terminated string.
strncpy is required to restrict the operation to 4 bytes. DLT IDs are not Null-terminated in dlt-daemon.
There was a problem hiding this comment.
Thank you, I have restored it. Since there is no length check of argv this is indeed needed.
There was a problem hiding this comment.
@michael-methner
Good point for no null-terminated for App and Context ID
|
Same topic is here: #634 |
|
Huge rework here: #732 |
|
Close as it is not recommended to use strcpy and strcat in modern C standard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix string truncation and overflow warnings so the compiler flags stringop-overflow and stringop-truncation can be enabled.
This shouldn't change any behaviour nor fix any bugs. It is just to be able to run the compiler with those flags so future bugs can be avoided. However I have added some extra checks for string lengths.
Most changes is to avoid using strncat and instead use strcat. This doesn't make the code safer but removes the false safeness of using strncat wrongly.