Fix Android build issues #598
Conversation
Binary "dlt-test-logstorage" doesn't have a source code and soong fails. This commit removes that binary. Added two defines "DLT_WRITEV_TIMEOUT_SEC, DLT_WRITEV_TIMEOUT_USEC" that are used by dlt_user_shared.c"
|
Hello @slawomiradamczyk |
|
Well I really don't know how, cause there is no source code for it? |
|
No worry @slawomiradamczyk |
| @@ -30,6 +30,8 @@ cc_defaults { | |||
| "-DDLT_LIB_USE_UNIX_SOCKET_IPC", | |||
| "-DCONFIGURATION_FILES_DIR=\"/vendor/etc\"", | |||
| "-DDLT_USER_IPC_PATH=\"/dev/socket\"", | |||
| "-DDLT_WRITEV_TIMEOUT_SEC=1", | |||
| "-DDLT_WRITEV_TIMEOUT_USEC=0", | |||
There was a problem hiding this comment.
Hello @slawomiradamczyk ,
can you remove the configuration change from the Android.bp? I assume that this is unrelated to the the compile issue.
I would then merge this PR, as we are currently not able upstream our changes due to limited team capacity.
There was a problem hiding this comment.
If I remove it it will stop compiling on Android. Those defines are required in file/src/shared/dlt_user_shared.c, which is part of libdlt target which is needed for dlt-logd-converter ;)
There was a problem hiding this comment.
you are right. i missed that one. Thanks for your contribution and patience.
Binary "dlt-test-logstorage" doesn't have a source code and soong fails. This commit removes that binary.
Added two defines "DLT_WRITEV_TIMEOUT_SEC, DLT_WRITEV_TIMEOUT_USEC" that are used by dlt_user_shared.c"