dlt-qnx-system improvement #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce injection messages for dlt-qnx-system It helps to completely disable parsing slog2 entries in some unnecessary cases. Signed-off-by: Bui Nguyen Quoc Thanh <[email protected]> dlt-qnx-system:potential leaks memory ctxt is allocated via new operator but there is no place delete later Use static variable instead of dynamic Signed-off-by: Bui Nguyen Quoc Thanh <[email protected]> dlt-qnx-system:memory improvement It seems that in a rare case the stack memory could face unexpected issue Try to use heap memory instead of stack Signed-off-by: Bui Nguyen Quoc Thanh <[email protected]> dlt-qnx-system:release memory in teardown The local stack variable to handle context map is handled incorrectly Solution is to apply an improvement with head memory and release memory properly Signed-off-by: Bui Nguyen Quoc Thanh <[email protected]> qnxsystem: Correct arguments Signed-off-by: Saya Sugiura <[email protected]>
michael-methner
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QNX:Injection for dlt-qnx-system
Introduce injection messages for dlt-qnx-system
It helps to completely disable parsing slog2 entries in some unnecessary cases.
dlt-qnx-system:potential leaks
memory ctxt is allocated via new operator but
there is no place delete later
Use static variable instead of dynamic
dlt-qnx-system:memory improvement
It seems that in a rare case the stack memory could face unexpected issue Try to use heap memory instead of stack
dlt-qnx-system:release memory in teardown
The local stack variable to handle context map is handled incorrectly Solution is to apply an improvement with head memory and release memory properly
qnxsystem: Correct arguments