Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dlt_multiple_files: remove superfluous mode bits and add header file to header list #462

Merged
merged 2 commits into from
Apr 12, 2023
Merged

dlt_multiple_files: remove superfluous mode bits and add header file to header list #462

merged 2 commits into from
Apr 12, 2023

Conversation

minminlittleshrimp
Copy link
Collaborator

@minminlittleshrimp minminlittleshrimp commented Mar 28, 2023 •
edited
Loading

This PR is an improvement for PR: #369

This was referenced Mar 28, 2023
Closed
Merged
@minminlittleshrimp
Copy link
Collaborator Author

minminlittleshrimp commented Mar 29, 2023 •
edited
Loading

Hello @danielweber2018
Could you kindly have a look into this fix? I would like to have your response about this fix.
Many thanks for your contribution.

@danielweber2018
Copy link
Contributor

danielweber2018 commented Apr 4, 2023 •
edited
Loading

Hello @danielweber2018 Could you kindly have a look into this fix? I would like to have your response about this fix. Many thanks for your contribution.

Hello @minminlittleshrimp ,
I had a look into your PR. From my side the additional rights are not necessary (and are not set in normal file logging too). Therefore your changings looks good for me.
Thanks for contributing and improving the feature.

@michael-methner michael-methner merged commit fae02b4 into COVESA:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-methner michael-methner michael-methner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minminlittleshrimp @danielweber2018 @michael-methner