dlt-logd-converter: fixes android 12 compilation #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienraillet
force-pushed
the
bugfix/fixes-android-12-compilation
branch
from
56f7e02 to
641b610
Compare
|
Hello @sebastienraillet For Android S and above, the path change: https://cs.android.com/android/platform/superproject/+/master:system/logging/liblog/include/log/ For backward compatibility, I still have no idea. If anybody has good suggestions please comment! |
|
Hello @minminlittleshrimp, |
* Since android 12 release (and the introduction of this commit https://chromium.googlesource.com/aosp/platform/system/ logging/+/b674866203f05957b2ac5db94c3c0fe3d1d36793), the define ANDROID_LOG_RDONLY and friends have been removed (see the commit for the explanation). Therefore, dlt-logd-converter can't compile anymore since this version. * ANDROID_LOG_RDONLY was a define on O_RDONLY. O_RDONLY is now used to allow the compilation on android 12 as well as previous versions * <log/logprint.h> include is removed because we aren't using any API from this file and moreover, this file shouldn't be included from vendor application (not part of public API) * Direct include on "system/core/include" inside Android.bp is removed because it was previously used to find <log/logprint.h>. This should be avoided. We should keep android build system providing right headers path for us :) Signed-off-by: Sébastien RAILLET <[email protected]>
sebastienraillet
force-pushed
the
bugfix/fixes-android-12-compilation
branch
from
641b610 to
144616e
Compare
michael-methner
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is about fixing a compilation issue which appear starting on android 12 for android-logd-converter
Description