dlt-user: fix potential non closed socket in init/free #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib/dlt_user.c
Outdated
| { | ||
| struct timespec ts; | ||
| bool in_loop = true; | ||
| bool *thread_running = (bool*)ptr; | ||
| *thread_running = true; |
There was a problem hiding this comment.
Hello @alexmohr ,
in which platform have you faced this issue?
I guess the assignment to true needs to be shifted below pthread_sigmask (for Android) and calling pthread_cleanup_push(). Otherwise a race condition still exists.
There was a problem hiding this comment.
Issue occurs on linux but only in unit tests when running them on a very fast machine. I moved the call and replaced the sleep with a condition variable
There was a problem hiding this comment.
Looks good to me. Thank you very much.
src/lib/dlt_user.c
Outdated
| * Check if the thread is running every 10ms | ||
| * */ | ||
| while (!housekeeper_thread_running) { | ||
| usleep(10000); |
There was a problem hiding this comment.
Can you use a semaphore instead? looping and sleeping is not that nice.
alexmohr
force-pushed
the
startup-dlt-housekeeper
branch
from
783d419 to
6286c57
Compare
wait until the house keeper is up and running this makes sure dlt_init / dlt_free in close succession closes this thread properly. Otherwise we might keep the dlt socket open Check if the thread is running every 10ms Signed-off-by: Alexander Mohr <[email protected]>
alexmohr
force-pushed
the
startup-dlt-housekeeper
branch
from
6286c57 to
cb44b68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait until the house keeper is up and running
this makes sure dlt_init / dlt_free in close succession closes this thread properly.
Otherwise we might keep the dlt socket open
Check if the thread is running every 10ms
The program was tested solely for our own use cases, which might differ from yours.
Licensed under Mozilla Public License Version 2.0
Alexander Mohr, [email protected], Mercedes-Benz Tech Innovation GmbH, imprint