Avoid memory corruption behind buffer wp in function dlt_getloginfo_conv_ascii_to_id

[michael-methner]

• Introduced new function dlt_getloginfo_conv_ascii_to_string for '\0' terminated strings
• Avoid printing garbage characters in dlt-control after APID and CTID (which are not null terminated anymore)
• Added unit test for dlt_client_parse_get_log_info_resp_text and dlt_getloginfo_conv_ascii_to_string

Signed-off-by: Michael Methner [email protected]

[thanhbnq]

Hello @michael-methner ,
I also would like to separate the PR to 2 commits: one for UT and one for source code.

[michael-methner]

Hello @michael-methner , I also would like to separate the PR to 2 commits: one for UT and one for source code.

Hello @thanhbnq , I want to keep them in one PR as only then the updated gtests are executed already by GitHub actions. Separating it into commits also does not make sense as they will be squashed anyhow.

[andreirusu96]

Hello, @michael-methner ! Thanks for letting me know of your PR!

The code looks good! I just have a small remark: since you've introduced dlt_getloginfo_conv_ascii_to_string(), maybe you would like to also make use of it for app/ctx description parsing in here and here.

Also, my PR ( #403 ) has 2 more improvements and you also suggested changing the cast in dlt_getloginfo_conv_ascii_to_uint16_t() to the same value as the return value.

Do you want to also include those improvements in your PR or would you prefer to do them in my PR (after a rebase)?

Thanks!

[michael-methner]

The code looks good! I just have a small remark: since you've introduced dlt_getloginfo_conv_ascii_to_string(), maybe you would like to also make use of it for app/ctx description parsing in here and here.

Thanks for the hint, actually this was my intention to use it here but somehow I missed to commit it. I fixed that one.

Also, my PR ( #403 ) has 2 more improvements and you also suggested changing the cast in dlt_getloginfo_conv_ascii_to_uint16_t() to the same value as the return value.

Do you want to also include those improvements in your PR or would you prefer to do them in my PR (after a rebase)?

Thanks!

I would say we can merge this one now and we will add the casts with your PR after rebase. So you will be the author of that change.

[thanhbnq]

Thank you @michael-methner and @andreirusu96 for PR and discussion.
I merged PR and please continue your next PR :)

Happy coding!
Thanh