Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Cygwin toolchain. #351

Merged

Conversation

DoctorNoobingstoneIPresume
Copy link
Contributor

Also tested with the latest version running on Windows XP (gcc-5.4.0)
(http://www.crouchingtigerhiddenfruitbat.org/cygwin/timemachine.html).

Also tested with the latest version running on Windows XP (gcc-5.4.0)
(http://www.crouchingtigerhiddenfruitbat.org/cygwin/timemachine.html).
@DoctorNoobingstoneIPresume
Copy link
Contributor Author

It seems that the open function is declared in <fcntl.h>, not in <unistd.h> (https://www.man7.org/linux/man-pages/man2/open.2.html).

@DoctorNoobingstoneIPresume
Copy link
Contributor Author

It seems that for the Cygwin toolchain, just like the Linux toolchain, we should not pass -lsocket to the linker.

@DoctorNoobingstoneIPresume
Copy link
Contributor Author

DoctorNoobingstoneIPresume commented Nov 13, 2021

Regarding CMake scripts:

I wonder why quotes are needed around ${CMAKE_SYSTEM_NAME} for the MATCHES operator, but not for the STREQUAL operator. (I could see that already quotes have indeed been used with MATCHES. I could also see that, without quotes, MATCHES does not seem to work as expected.)

Anyway, maybe it is useful (good practice, good model) to use quotes (almost) everywhere around variable names. For example, should/might we replace ${CMAKE_SYSTEM_NAME} with "${CMAKE_SYSTEM_NAME}" everywhere ?

@ssugiura ssugiura merged commit aa1364f into COVESA:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants