Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in the lib name in the README that will cause a linking error in the cmake #365

Closed
bilalmta opened this issue Jan 25, 2022 · 1 comment · Fixed by #372
Closed

Typo in the lib name in the README that will cause a linking error in the cmake #365

bilalmta opened this issue Jan 25, 2022 · 1 comment · Fixed by #372

Comments

@bilalmta
Copy link

In this Readme: https://github.com/COVESA/dlt-daemon/blob/master/doc/dlt_for_developers.md

Under this part DLT with cmake, the lib name should be Genivi::dlt not Genivi::DLT

If you tried to use the uppercase lib name it would give you a linking error.
@bilalmta bilalmta mentioned this issue Jan 25, 2022
Closed
mawillers added a commit to mawillers/dlt-daemon that referenced this issue Apr 9, 2022
@mawillers
Fix the target name in documentation
d54b417 
Closes COVESA#365

Signed-off-by: Martin Willers <[email protected]>
@mawillers mawillers mentioned this issue Apr 9, 2022
Merged
@mawillers
Copy link
Contributor

@bilalmta, please review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the target name in documentation mawillers/dlt-daemon
2 participants
@bilalmta @mawillers