Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle ERA5 leap year Feb inputs #73

Closed
aekiss opened this issue Apr 6, 2022 · 1 comment · Fixed by #74
Closed

handle ERA5 leap year Feb inputs #73

aekiss opened this issue Apr 6, 2022 · 1 comment · Fixed by #74
Assignees
@micaeljtoliveira

Comments

@aekiss
Copy link
Contributor

aekiss commented Apr 6, 2022 •
edited
Loading

The end_day field in forcing.json is always replaced by 28 in February, even in a leap year, causing run failure:
COSIMA/access-om2#242 (comment)

Looks like this could be fixed with some small changes to https://github.com/COSIMA/libaccessom2/blob/master/libutil/src/util.F90
perhaps using isLeapYear from datetime_module.
@micaeljtoliveira micaeljtoliveira mentioned this issue Apr 7, 2022
Merged
@aekiss aekiss closed this as completed in #74 Apr 7, 2022
@aekiss
Copy link
Contributor Author

aekiss commented Apr 7, 2022

Test run works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micaeljtoliveira micaeljtoliveira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle ERA5 leap year Feb inputs COSIMA/libaccessom2
2 participants
@micaeljtoliveira @aekiss