From 1cad85bd5a490eb45ef58525328199e3ade10dcb Mon Sep 17 00:00:00 2001 From: Greg Tunink Date: Fri, 24 Jan 2025 16:32:12 -0600 Subject: [PATCH] Revert concurrent-ruby gem downgrade; fix logger dependency Bad Stack Overflow advice "fixed" this issue, but with other very unwanted consequences This fix is much better and mirrors how Rails itself fixed the issue --- Gemfile | 3 --- Gemfile.lock | 11 +++++------ config/boot.rb | 1 + 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/Gemfile b/Gemfile index 496967d..d7cfe83 100644 --- a/Gemfile +++ b/Gemfile @@ -34,9 +34,6 @@ gem 'jbuilder', '~> 2.7' # Reduces boot times through caching; required in config/boot.rb gem 'bootsnap', '>= 1.4.4', require: false -# Fix for uninitialized constant Logger, see https://stackoverflow.com/questions/79360526/uninitialized-constant-activesupportloggerthreadsafelevellogger-nameerror -gem 'concurrent-ruby', '1.3.4' - group :development, :test do # Call 'byebug' anywhere in the code to stop execution and get a debugger console gem 'byebug', platforms: [:mri, :mingw, :x64_mingw] diff --git a/Gemfile.lock b/Gemfile.lock index 5856fef..2ffd672 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -90,7 +90,7 @@ GEM rack-test (>= 0.6.3) regexp_parser (>= 1.5, < 3.0) xpath (~> 3.2) - concurrent-ruby (1.3.4) + concurrent-ruby (1.3.5) crass (1.0.6) date (3.4.1) erubi (1.13.1) @@ -98,7 +98,7 @@ GEM ffi (1.17.1) globalid (1.2.1) activesupport (>= 6.1) - i18n (1.14.6) + i18n (1.14.7) concurrent-ruby (~> 1.0) jbuilder (2.13.0) actionview (>= 5.0.0) @@ -136,7 +136,7 @@ GEM net-smtp (0.5.0) net-protocol nio4r (2.7.4) - nokogiri (1.18.1) + nokogiri (1.18.2) mini_portile2 (~> 2.8.2) racc (~> 1.4) public_suffix (6.0.1) @@ -191,7 +191,7 @@ GEM sprockets (> 3.0) sprockets-rails tilt - selenium-webdriver (4.27.0) + selenium-webdriver (4.28.0) base64 (~> 0.2) logger (~> 1.4) rexml (~> 3.2, >= 3.2.5) @@ -238,7 +238,6 @@ DEPENDENCIES bootstrap-sass (~> 3.4.1) byebug capybara (>= 3.26) - concurrent-ruby (= 1.3.4) jbuilder (~> 2.7) jquery-rails (~> 4.3) listen (~> 3.3) @@ -258,4 +257,4 @@ RUBY VERSION ruby 3.1.6p260 BUNDLED WITH - 2.3.27 + 2.5.23 diff --git a/config/boot.rb b/config/boot.rb index 3cda23b..65bddf3 100644 --- a/config/boot.rb +++ b/config/boot.rb @@ -1,4 +1,5 @@ ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__) require "bundler/setup" # Set up gems listed in the Gemfile. +require "logger" # Fix concurrent-ruby removing logger dependency Rails is missing require "bootsnap/setup" # Speed up boot time by caching expensive operations.