-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.4.0 tag commit #1345
Comments
@durack1 we need to update it with few more things but this is a good start. I will add my suggestion to it later today. |
@aashish24 no problem, it would be great to clarify things properly so that there will be no need to move tags multiple times which just gets everyone confused.. If we set out a plan with a very defined step-by-step process, this can just be followed for each subsequent release.. |
Sure 👍 Actually why don't we put it under the source code? Thoughts? |
@aashish24 sure, that's another option - I just think having a step by step will ensure that the confusion of 2.2 and earlier tags isn't replicated |
@doutriaux1 can we tag 2.4 rc1 today? |
@chaosphere2112 can you please re-run your release note scraper to produce the |
Release notes available here. |
@chaosphere2112 thanks for this! |
@chaosphere2112 gatekeeper tag should be ommited, it's really only for us it's fixed in a branch and should be closed. |
this is great. Instead of *** can we use "Others" |
Or something similar. |
@chaosphere2112 can you recreate the release notes again please? It looks like there is some cleaning up to be done.. |
@chaosphere2112 let's wait until it's tagged. |
@aashish24 probably time to revisit the steps outlined at the top.. |
I think these steps are good but missing
Yep I can edit - @durack1 |
@aashish24 feel free to rearrange this as you see fit (you should be able to edit your issue above - use the pen item in the top right corner of the issue box). The original intention was to outline ALL the steps one by one so that things are done once right, rather than previously when duplicate tag points confused folks for a while.. |
@chaosphere2112 I just had a peek at the latest version of the A couple of these are incorrect, there have been multiple update hops since |
@chaosphere2112 @doutriaux1 @aashish24 some other missing issues/completed PRs to be added to the release notes: #1635 - Update Vacumm 2.5.1 To 3.0.0 |
@durack1 I'll update the changelog as soon as I get in; my other laptop needs to get auth'd to the external network first. |
As an added bit of usefulness with this release, this should go in the release notes: a list of the major new features in 2.4 as well as examples on how to use them. https://github.com/UV-CDAT/uvcdat/wiki/2.4-Features-Documentation |
@doutriaux1 @aashish24 @sankhesh Feel free to update that document as necessary; if you come up with new examples, I'll add them to the gallery. |
@chaosphere2112 this is unreal - such "new features" will be a great addition to highlight in the release notes, and continue to build the documentation tree through time.. It's great we have all these new colormaps too! One very happy user here.. |
@durack1 Helped find a bunch of bugs, too! |
@chaosphere2112 sorry to bug again about the release notes, but they don't seem to have grabbed the changes noted above here and here |
@chaosphere2112 @doutriaux1 @dnadeau4 I think with the new colormap stuff noted above, you might be able to close #906 - take a peek and close if you think it's solved.. |
@durack1 I'm looking into that now. |
@chaosphere2112 nope, it seems these still need tweaks - I think what is happening here is that: Enhancement: Update cython to 0.22 -> 0.23.4 #1538 (I updated the issue title) |
@chaosphere2112 I've just been peeking at the matplotlib available colormaps, and am wondering if creating a similar graphic to that found at: http://matplotlib.org/1.2.1/examples/pylab_examples/show_colormaps.html (linked below) which includes all the matplotlib and vcs colormaps wouldn't be a good idea? >>> import matplotlib
>>> print matplotlib.__version__
1.5.0
>>> import matplotlib.pyplot as plt
>>> maps = sorted(m for m in plt.cm.datad if not m.endswith("_r"))
>>> for count,a in enumerate(maps):
... print a Yields 72 colormaps alone, then add the |
@durack1 Yeah, that's a good idea. I'll get something thrown together tomorrow. |
@chaosphere2112 this might be an even more up-to-date page to base off - it includes the |
@chaosphere2112 some new palettes can be found at: https://github.com/durack1/pylib/blob/master/colourLib.py Sorry I took so long, these were in pretty bad shape and the conversion took longer than I thought.. |
@durack1 OK, I'll take a look through these tomorrow (once I finish up our UV-CDAT poster for the F2F). |
@chaosphere2112 no time stress.. If they make it into |
@durack1 I believe I've written the code needed to import your colormaps (were they in blue, green, red?). Some of them looks slightly redundant; this chart is matplotlib on the top, VCS on the bottom left, and yours on the bottom right. Are there any in particular that you think the community would benefit from? Also, I can give you the code I used to convert them into VCS if you want it for your own usage. |
@chaosphere2112 excellent, thanks for this! You're right there is some redundancy, however the subtle differences with my palettes that are harder to ascertain are the exclusion of a white (or grey) separator between halves of the color scales.. Now that we have all the palettes to peruse it could be a good idea to trim the redundant/duplicated ones.. I also wonder if you've managed to grab all the latest |
Yup, I'm looking into that now |
@chaosphere2112 to be honest I'd wonder whether some of mine are |
I'll take a look and see! May well be. Hm... it might be handy to add a flag to colormap objects to flip them, so we can easily have |
@chaosphere2112 yeah, I think it's redundant to have two numerically identical (but flipped) palettes stored - so having the ability to reverse these (so in some cases, from red -> blue to blue -> red) is a really nice feature.. It'd be great to have that built into the |
@durack1 Looks like |
@aashish24 @doutriaux1 just wondering if the |
@durack1 yes, it will, I am in the process of it. Should be done tonight/tomorrow. |
@durack1 @aashish24 @doutriaux1 I'm updating the changelog and I'll merge in my two 2.4 branches for the website, so my links will be in place shortly. |
@chaosphere2112, it seems the release notes still need tweaks, we're a bit behind on the patch updates that aren't up-to-date to what's in Enhancement: Update cython to 0.22 -> 0.23.4 #1538 (I updated the issue title) |
@chaosphere2112 Could you please push those release notes to the Github Wiki to replace 2.4.0RC3 Release Notes page? |
Released! |
@chaosphere2112 if you would happen to have the code handy it would be great. Otherwise don't worry I can rewrite it in 15mn. Thx |
That color map code? Long gone, I'm afraid. Did @durack1 finally get this onto your list 😆? |
@chaosphere2112, who says persistence doesn't pay?! |
no worries @chaosphere2112, it's a 15mn job top. |
@doutriaux1 @aashish24 might I suggest the following step-by-step is undertaken for
2.4.0
tagging? This should clear up some of the issues that have popped up with2.2.0
:2.4.0
)v2.2.0
)2.4.0
release:CMOR_BRANCH="uvcdat-2.4.0"; LIBCDMS_BRANCH="uvcdat-2.4.0"; VISTRAILS_BRANCH="uvcdat-2.4.0"; VTK_BRANCH="uvcdat-2.4.0"; UVCMETRICS_BRANCH="uvcdat-2.4.0"
README.md
with updatedStable version
info (should be2.4.0
)2.4.0
tag point for UV-CDAT/uvcdat repoREADME.md
with updatedZenodo DOI
info2.4.0
tag point to new commit2.4.0
) are noted for build notes: linux, MacOS X etc2.4.0
tag point set, reset allmaster
checkout tag points to point back touvcdat-master
tags (PARAVIEW_BRANCH="uvcdat-master"
etc)uvcdat-master
to2.5.0
(odd minor [major.minor.patch] number indicating development version)@doutriaux1 were there any other steps that aren't included above, if so please add/edit..
The text was updated successfully, but these errors were encountered: