Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: The alarm sound continues to play in the background even when attempting to select a new sound or exiting the dialog. #536

Closed
davidodejobi opened this issue Mar 28, 2024 · 1 comment · Fixed by #596
Assignees
Labels
bug Something isn't working

Comments

@davidodejobi
Copy link

Description

The alarm sound continues to play in the background even when attempting to select a new sound or exiting the dialog.

Steps to Reproduce:

Click on the FAB (Floating action button) to add a new alarm.
Click on the Choose Ringtone button.
Click on the play icon button on any of your existing tones.

Expected Behavior:
The Upload Ringtone button should verify if a ringtone is currently playing.
If no tone is playing, it should proceed to open the folders to select a new tone.
If a tone is playing, it should stop the current tone before allowing selection of a new one.
Pressing the Done button or closing the dialog should also stop any playing tone.

Actual Behavior:
Once a sound starts playing, it continues even after performing this actions

  1. After setting the alarm
  2. When the Done button is pressed
  3. When the dialog is closed
  4. When adding a new sound

Possible Solution:
Implement a check before opening the ringtone selection dialog to ensure no tones are currently playing. Additionally, ensure that pressing the "Done" button or closing the dialog stops any playing tones.

Screenshots

CleanShot 2024-03-28 at 06 50 28

@davidodejobi davidodejobi added the bug Something isn't working label Mar 28, 2024
@davidodejobi
Copy link
Author

@MarkisDev please assign this to me while I work on this

@AryanSarafDev AryanSarafDev linked a pull request Aug 24, 2024 that will close this issue
3 tasks
@AryanSarafDev AryanSarafDev self-assigned this Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants