Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDhap valid input check fails #14

Closed
s-rashmi opened this issue Oct 1, 2021 · 3 comments
Closed

LDhap valid input check fails #14

s-rashmi opened this issue Oct 1, 2021 · 3 comments

Comments

@s-rashmi
Copy link

s-rashmi commented Oct 1, 2021

Hi, just a minor issue!
I had given a list of 100 SNPs for LDhap function. The output received was
Error in data_out2[1, ] : incorrect number of dimensions
Couldn't figure out. So I ran the LDhap.R code from github separately and got the error message from the website "error: Maximum variant list is 30 RS numbers or coordinates".

I believe one more set of outer brackets is required here at line 94 --> if( !(length(snps) > 1) & (length(snps) <=30) ){

Thanks a lot!

@timyers
Copy link
Collaborator

timyers commented Oct 1, 2021

Thank you, Rashmi. I'll fix that. I'm currently in the middle of updating LDhap to include your suggestion from issue #13. The new update will have an option to include genomic coordinates. I'm almost ready to push the updates to Github.
Thanks for your contributions!
Regards,
T

@timyers
Copy link
Collaborator

timyers commented Oct 1, 2021

Fixed issue. Changes uploaded to dev version on Github and will be included in the next submission to CRAN.

@s-rashmi
Copy link
Author

s-rashmi commented Oct 2, 2021

Thanks a lot Tim :)

@s-rashmi s-rashmi closed this as completed Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants