Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use OAuth for authentication #266

Closed
thaowei opened this issue Oct 23, 2019 · 4 comments
Closed

Should use OAuth for authentication #266

thaowei opened this issue Oct 23, 2019 · 4 comments
Assignees

Comments

@thaowei
Copy link

thaowei commented Oct 23, 2019

This app should really use OAuth for authentication, instead of using the username and password directly. I would very much prefer if the OAuth web flow were used, but the OAuth non-web flow is still better than the current situation.

Since it's built on Electron using Octokit, it should be rather trivial to do so.

This also means the app will be able to handle 2FA properly.

@JunWei96
Copy link
Contributor

I agree that OAuth is definitely much better. However, currently github doesnt allow CORS access to its OAuth API. Don't think having Electron and Octokit can bypass this restriction.
For reference: isaacs/github#330

@thaowei
Copy link
Author

thaowei commented Oct 27, 2019

CORS can be disabled in Electron. See here (search for webSecurity).

I haven't exactly thought this through, but my gut feeling tells me there aren't really major security implications in this case, since no "untrusted" code is run in the Electron browser. (Assuming you trust the thousands of dependencies brought in from npm...)

@Lucria
Copy link

Lucria commented Oct 30, 2019

I agree... should really consider integration with OAuth for proper security management.

@JunWei96 JunWei96 self-assigned this Jan 19, 2020
@JunWei96
Copy link
Contributor

JunWei96 commented Feb 3, 2020

Close via #291

@JunWei96 JunWei96 closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants