From a99993a50eb135e0a6b626b6b669c8c89c558da6 Mon Sep 17 00:00:00 2001 From: Ben Schroeter Date: Tue, 7 Jan 2025 11:01:06 +1100 Subject: [PATCH 1/2] Added details around benchcab outputs to the PR template. Fixes #517 --- .github/pull_request_template.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 12422e1b5..717b2d042 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -20,8 +20,11 @@ Please delete options that are not relevant. ## Checklist -- [ ] The new content is accessible and located in the appropriate section. -- [ ] I have checked that links are valid and point to the intended content. +- [ ] The new content is accessible and located in the appropriate section +- [ ] I have checked that links are valid and point to the intended content - [ ] I have checked my code/text and corrected any misspellings +- [ ] I have included relevant test results (i.e. benchcab outputs or path to readable logs) to ensure that the code compiles, runs and is bitwise compatible to the main branch* + +**Unless a a change in outputs is expected, in which case add someone with relevant scientific expertise as a reviewer* Please add a reviewer when ready for review. From d593558a4c76be8c2c8b559f1b207fc4f3c2c185 Mon Sep 17 00:00:00 2001 From: Ben Schroeter Date: Wed, 8 Jan 2025 13:27:39 +1100 Subject: [PATCH 2/2] Update .github/pull_request_template.md Co-authored-by: Claire Carouge --- .github/pull_request_template.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 717b2d042..77e5ee4c6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -23,8 +23,11 @@ Please delete options that are not relevant. - [ ] The new content is accessible and located in the appropriate section - [ ] I have checked that links are valid and point to the intended content - [ ] I have checked my code/text and corrected any misspellings -- [ ] I have included relevant test results (i.e. benchcab outputs or path to readable logs) to ensure that the code compiles, runs and is bitwise compatible to the main branch* -**Unless a a change in outputs is expected, in which case add someone with relevant scientific expertise as a reviewer* +## Testing + +- [ ] Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line. + +- [ ] Are the changes non bitwise-compatible with the main branch because of a bug fix or a feature being newly implemented or improved? If yes, add the link to the modelevaluation.org analysis versus the main branch or equivalent results below this line. Please add a reviewer when ready for review.