Missing variables in MPI messing up with soil conductivity

[ccarouge]

When cable_user%soil_thermal_fix is True, we calculate the soil conductivity using this function:

CABLE/src/science/soilsnow/cbl_conductivity.F90

Line 11 in 09a1243

FUNCTION total_soil_conductivity(ssnow,soil)

It is called from stempv:

CABLE/src/science/soilsnow/cbl_stempv.F90

Lines 57 to 61 in 09a1243

	IF (cable_user%soil_thermal_fix) THEN
	ccnsw = total_soil_conductivity(ssnow,soil)
	ELSE
	ccnsw = old_soil_conductivity(ssnow,soil)
	ENDIF

This new soil conductivity calculation is using the parameters soil%sand_vec, soil%ssat_vec, soil%watr, soil%cnsd_vec. These parameters were introduced for the groundwater scheme. It turns out these parameters were not fully implemented in main since the groundwater scheme isn't fully implemented. Initialisations and MPI implementations are faulty.

It could be these parameters or other parameters for the ground water are currently used in the code elsewhere. In this case, fixing this issue would have more impact than the soil conductivity alone. But I do not intend search to see if that is the case.