Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical structure #186

Closed
AlexandreSajus opened this issue Jan 13, 2022 · 4 comments · Fixed by #227
Closed

Vertical structure #186

AlexandreSajus opened this issue Jan 13, 2022 · 4 comments · Fixed by #227
Assignees
Labels
enhancement New feature or request

Comments

@AlexandreSajus
Copy link
Contributor

To help with lowering the barrier of entry between Jupyter and Pyflow, we could adopt a vertical structure where blocks are aligned top to bottom instead of left to right.

A good first step towards this would be having top and bottom sockets

@AlexandreSajus AlexandreSajus added the enhancement New feature or request label Jan 13, 2022
@MathisFederico
Copy link
Member

To help with lowering the barrier of entry between Jupyter and Pyflow, we could adopt a vertical structure where blocks are aligned top to bottom instead of left to right.

A good first step towards this would be having top and bottom sockets

Yup, clearly one of the best ideas, flow should be from up to down as this is how you write lines of code !

@FabienRoger
Copy link
Contributor

Sockets are now on the top and bottom of each block (in the middle of each block side, evenly spaced out if there is > 1 socket).
image

@FabienRoger
Copy link
Contributor

The new look of post-conversion ipynb

image

I increased the height of each block to be greater than "just the code" so that a few lines of codes can be added without having to move everything down.
This is a quick fix, but I am afraid that we should think of something a bit more clever to allow the user to insert code / blocks in the middle of the graph without having to manually push everything down each time.

@FabienRoger
Copy link
Contributor

This is a quick fix, but I am afraid that we should think of something a bit more clever to allow the user to insert code / blocks in the middle of the graph without having to manually push everything down each time.

See #228 For a way of fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants