Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gendered*Names properties keyed by English strings #77

Closed
bhollis opened this issue Sep 9, 2017 · 6 comments
Closed

gendered*Names properties keyed by English strings #77

bhollis opened this issue Sep 9, 2017 · 6 comments
Assignees
@vthornheart-bng
Labels
bug filed A bug has been filed in BNet's internal bug tracking system for this request/report. bug ready for release

Comments

@bhollis
Copy link

bhollis commented Sep 9, 2017

I would have expected these properties to be keyed on Destiny.DestinyGender values, but instead they're keyed on the strings "Male" and "Female" which aren't super easy to bridge from a localized DestinyGenderDefinition.
@vthornheart-bng
Copy link
Contributor

Hmm, I could have sworn we had a bug on this already, but I can't find it now. Yeah, that appears to be an error in how our serializer interprets enums as dictionary keys. I'll have to look into that.

@vthornheart-bng vthornheart-bng self-assigned this Sep 9, 2017
@vthornheart-bng vthornheart-bng added ready for release bug filed A bug has been filed in BNet's internal bug tracking system for this request/report. labels Nov 15, 2018
@vthornheart-bng
Copy link
Contributor

TFS: 737266

And fixing it for next release, finally.

@vthornheart-bng
Copy link
Contributor

Fixed as of v2.3.3 deployment (12/11)!

@bhollis
Copy link
Author

bhollis commented Dec 14, 2018

I'm still not seeing these properties in the races/classes loaded from the latest manifest.
screen shot 2018-12-13 at 9 28 32 pm

https://data.destinysets.com/i/Race:898834093

@bhollis bhollis mentioned this issue Dec 20, 2018
Closed
@vthornheart-bng
Copy link
Contributor

Sounds like this might have accidentally missed the deployment.

@vthornheart-bng
Copy link
Contributor

This should be fixed as of today's deployment (1/29)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthornheart-bng vthornheart-bng

Labels
bug filed A bug has been filed in BNet's internal bug tracking system for this request/report. bug ready for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhollis @vthornheart-bng