Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destiny2.GetActivityHistory documentation defect #1932

Open
skyriderdragoon opened this issue Dec 31, 2024 · 4 comments
Open

Destiny2.GetActivityHistory documentation defect #1932

skyriderdragoon opened this issue Dec 31, 2024 · 4 comments

Comments

@skyriderdragoon
Copy link

Documentation for this api call states a querystring parameter is "mode" however the correct parameter is "modes"

@aadam-bng aadam-bng added the bug label Dec 31, 2024
@aadam-bng
Copy link
Collaborator

Thanks for the report! I've filed a bug for this and we'll see if we can address this soon.

@aadam-bng aadam-bng added the bug filed A bug has been filed in BNet's internal bug tracking system for this request/report. label Dec 31, 2024
@aadam-bng
Copy link
Collaborator

Do you have a screenshot or log, so we can see the GetActivityHistory API working with the "modes" parameter instead of "mode"? The latter ought to work when we tried to repro.

@skyriderdragoon
Copy link
Author

skyriderdragoon commented Jan 1, 2025

Hi Ash,

Attached screenshots show my calls for the API where the only difference is a call to Mode and call to Modes, I have realised that the issue is slightly different to the original report Mode and Modes both work for calls where Mode only supports a single request and Modes supports 1 or more requests..

I believe the documentation should reflect Mode only allowing 1 input but modes allowing more than 1.

Modes - Multiple Queries

Modes(Multiple)

Mode - Multiple Queries

Mode(Multiple)

Modes - Single Query

Modes(Single)

###Mode - Single Query
Mode(Single)

@aadam-bng
Copy link
Collaborator

Thanks for the additional information. "Mode" is the only URL parameter we listen for, and expect a single value. The "Modes" returned are the entire hierarchy of modes the PGCR falls into. In your example: 7 is AllPVE, and 4 is Raid. So you could obtain this particular PGCR by querying either of those modes.

The API does not currently support getting two types of PGCRs at once (e.g. trying to get "Raids" and "Dungeons" in the same response). We can track this as an enhancement though.

@aadam-bng aadam-bng added enhancement and removed bug bug filed A bug has been filed in BNet's internal bug tracking system for this request/report. labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants