-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Angular 14 #93
feat: Angular 14 #93
Conversation
remove a bunch of extraneous code and tests
running next semantic release will increment this to 14
BREAKING CHANGE: description, key, email, and user are now set only properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good for the most part!
I noticed there were a couple files with no ending blank line, but that is mostly a nitpick
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/BugSplat-Git/bugsplat-ng.git" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seeing a few of these no new lines. not sure if that is important to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried fixing this but since i couldn't get it within a few minutes i decided to bail!
# [5.0.0](v4.0.1...v5.0.0) (2022-08-02) ### Features * Angular 14 ([#93](#93)) ([a5983b9](a5983b9)) ### BREAKING CHANGES * updates to package version to stay in sync with Angular versions * chore: fix linting issues * chore: silence ts test errors * chore: squash more ts test errors * refactore: add semi * feat: use bugsplatJs to keep track of desc, key, email, user * description, key, email, and user are now set only properties * chore: fix lib build * chore: fix sample * chore: add tests for bugsplat-js setDefaults * chore: fix weird missing .eslintrc.json * chore: add lint rule for single quotes * chore: remove todo * fix: fix semantic release committing wrong version info
# [14.0.0](v13.0.0...v14.0.0) (2022-08-02) ### Features * Angular 14 ([#93](#93)) ([a5983b9](a5983b9)) ### BREAKING CHANGES * updates to package version to stay in sync with Angular versions * chore: fix linting issues * chore: silence ts test errors * chore: squash more ts test errors * refactore: add semi * feat: use bugsplatJs to keep track of desc, key, email, user * description, key, email, and user are now set only properties * chore: fix lib build * chore: fix sample * chore: add tests for bugsplat-js setDefaults * chore: fix weird missing .eslintrc.json * chore: add lint rule for single quotes * chore: remove todo * fix: fix semantic release committing wrong version info
🎉 This PR is included in version 14.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* chore: prepare for CI/CD remove a bunch of extraneous code and tests * chore fix test errors * chore: add CI/CD * chore: fix build warnings * chore: add symbol upload secrets * chore: fix secrets * chore: ran npm i * chore: ran ng update * chore: remove deprecated defaultProject option * chore: update package version to 13 * chore: fix linting issues * chore: silence ts test errors * chore: squash more ts test errors * refactore: add semi * feat: use bugsplatJs to keep track of desc, key, email, user * chore: fix lib build * chore: fix sample * chore: add tests for bugsplat-js setDefaults * chore: fix weird missing .eslintrc.json * chore: add lint rule for single quotes * chore: remove todo * fix: fix semantic release committing wrong version info BREAKING CHANGE: Description, key, email, and user are now set only properties. Updates to package version to stay in sync with Angular versions.
# [14.0.0](v13.0.0...v14.0.0) (2022-08-02) ### Bug Fixes * fix semantic-release ([9a47923](9a47923)) ### Features * Angular 14 ([#93](#93)) ([c8abb02](c8abb02)) ### BREAKING CHANGES * Description, key, email, and user are now set only properties. Updates to package version to stay in sync with Angular versions.
# [14.0.0](v13.0.0...v14.0.0) (2022-08-02) ### Bug Fixes * fix semantic-release ([9a47923](9a47923)) ### Features * Angular 14 ([#93](#93)) ([c8abb02](c8abb02)) ### BREAKING CHANGES * Description, key, email, and user are now set only properties. Updates to package version to stay in sync with Angular versions.
Description
Updates sample to Angular 14. Updates ng-packagr. Ensures Angular 14 compatibility. Fixes linting.
Resolves #90
Checklist