Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error serializing circular JSON #108

Merged
merged 1 commit into from
Jul 24, 2023
Merged

fix: error serializing circular JSON #108

merged 1 commit into from
Jul 24, 2023

Conversation

bobbyg603
Copy link
Member

@bobbyg603 bobbyg603 commented Jul 21, 2023

Description

The response object is circular so we can't serialize it. Seems like serializing the server response makes more sense.

Also updates the build scripts and runs npm audit.

Checklist

  • Tested manually
  • Unit tests pass with no errors or warnings
  • Documentation updated (if applicable)
  • Reviewed by at least 1 other contributor

add test scripts
run npm audit
@bobbyg603 bobbyg603 requested a review from daveplunkett July 21, 2023 18:21
@bobbyg603 bobbyg603 merged commit c482f49 into main Jul 24, 2023
@bobbyg603 bobbyg603 deleted the circular-json branch July 24, 2023 10:59
bobbyg603 pushed a commit that referenced this pull request Jul 24, 2023
## [15.0.1](v15.0.0...v15.0.1) (2023-07-24)

### Bug Fixes

* error serializing circular JSON ([#108](#108)) ([c482f49](c482f49))
@bobbyg603
Copy link
Member Author

🎉 This PR is included in version 15.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants