Missing UI Elements in titlebar/tabbar on macOS in 2020.01

[jrappen]

Description

Waterfox 2020.01 on macOS is missing UI Elements in the titlebar / tabbar.

Screenshots

Configuration

Waterfox:
  build: 2020.01
  channel: current
    portable: false
  platform: osx x64
    version: macOS Catalina 10.15.2 (19C57)
  hardware: MBP 15" 2018, i9 2.9GHz, 32GB, 1TB, Radeon Pro 560X

[jrappen]

As a test I tried with the all included themes (default, light, dark), same issue with all.

[hawkeye116477]

Seems that's duplicate of #1350.

[MrAlex94]

@hawkeye116477

So the changes to this file are the reason for the titlebar buttons to not show on macOS. The position for them is all messed up though when adding macOS specific if guards. Which bit effects the distance to the tab?

[hawkeye116477]

I'm not sure what you mean by bit. You'll need to set padding-left for element with id TabsToolbar.
Anyway, I see now that I bit much complicated that and can be made simpler, so you won't need to add padding or set distance from top. It's almost ready, so I'll make PR with fixes later.

[PK2702]

#1393