Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(loadImage): add stream and alt support #486

Merged
merged 1 commit into from
Jun 28, 2022
Merged

feat(loadImage): add stream and alt support #486

merged 1 commit into from
Jun 28, 2022

Conversation

twlite
Copy link
Contributor

@twlite twlite commented Jun 27, 2022

Additions to the #483

This PR adds support for internal.Readable streams as image source and ability to set alt via loadImage.

Brooooooklyn
Brooooooklyn approved these changes Jun 28, 2022
View reviewed changes
Copy link
Owner

@Brooooooklyn Brooooooklyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Brooooooklyn Brooooooklyn merged commit 671c4b1 into Brooooooklyn:main Jun 28, 2022
@twlite twlite deleted the loadImage/stream branch June 28, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twlite @Brooooooklyn