Move docker build to plug repo #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenhagg
commented
Aug 23, 2021
| WORKDIR /PostREISE | ||
| RUN pipenv sync --dev --system; | ||
| RUN pip install . | ||
| RUN pip install ../PowerSimData |
There was a problem hiding this comment.
Since we will soon be restricting the version of powersimdata specified in postreise, we need to install from the develop branch for this to be consistent with the current setup.
|
Relates to #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Consolidate the builds currently in powersimdata and postreise, which prevents having an out of date postreise image or the need to synchronize builds across repos. Currently, only the
latesttag is built, but in the future I'm thinking the simplest option would be to have astabletag which builds the latest versioned postreise image, and make that the default in the compose files included here.What the code is doing
Add the Dockerfile and update things as necessary. In particular, the
.dev.ymlfile provided for users who want to build locally, which now works without cloning any other repos.Testing
Ran the build with docker compose using the override file. Quick test using the resulting image to make sure we can still import from powersimdata and postreise.
Time estimate
15 min