-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: native installation #62
Conversation
@jon-hagg I'm following these instructions on a Mac using your https://github.com/Breakthrough-Energy/PowerSimData/tree/jon/windows branch.
I know how to fix that issue but I can't remember what we decided on how a new user should deal with this? |
We could move psycopg2 to optional-requirements.txt, as it's not currently used other than tests. Will just need to check if it requires moving some import statements. Edit: done in this PR Breakthrough-Energy/PowerSimData#480 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the installation goes smoothly now that the psycopg2 package is moved in the optional PowerSimData requirements in this PR.
source/user/installation_guide.rst
Outdated
The framework can be used natively after some initial setup. This first requires the following: | ||
|
||
+ install julia 1.5 and create an environment as described in `REISE.jl`_ | ||
+ clone `PowerSimData`_ and `REISE.jl`_ (preferably in the same directly) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the same directly -> in the same directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way is it prefearable or mandatory. What happens if you don't do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not actually sure 🙃 not aware of assumptions in the code, but haven't tested in other configurations. Wouldn't be surprised if nesting the repositories or something could cause weirdness, so wanted to encourage following a known setup.
source/user/installation_guide.rst
Outdated
|
||
The framework can be used natively after some initial setup. This first requires the following: | ||
|
||
+ install julia 1.5 and create an environment as described in `REISE.jl`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be consistent with the rest of the doc, should these bullet points be capitalized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go for now.
Purpose
Describe the process for installing the framework natively. The output looks like this
Time to review
20 mins