Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge develop into main for v0.1 release #90

Merged
merged 108 commits into from
Jun 1, 2021
Merged

chore: merge develop into main for v0.1 release #90

merged 108 commits into from
Jun 1, 2021

Conversation

danielolsen
Copy link
Contributor

Pull Request doc

Purpose

Merge the develop into main, so that we can create a v0.1 release.

Proposed release notes

Closed Issues

Merged pull requests (features)

Merged pull requests (fixes, etc)

Time estimate

5 minutes.

danielolsen and others added 30 commits May 4, 2021 20:58
chore: add skeleton of grid_to_switch function
feat: add function to create data frame for trans_params file
feat: add function to create data frame for load_zones file
feat: add function to create data frame for financials file
feat: add function to create data frame for fuels file
…y_sources

feat: add function to create data frame for non-fuel energy sources
@danielolsen danielolsen self-assigned this Jun 1, 2021
@rouille
Copy link
Collaborator

rouille commented Jun 1, 2021

In the release notes, feat: add skeleton for applying temporal mapping to inputs (#56) (@danielolsen) is in the fixes, I believe it shoud be in the feat, no?

@danielolsen
Copy link
Contributor Author

In the release notes, feat: add skeleton for applying temporal mapping to inputs (#56) (@danielolsen) is in the fixes, I believe it shoud be in the feat, no?

The line is a little blurry: that PR does not add any functional code, but it does create a higher-level function to manage lower-level code. I can move that to the features if you want.

@rouille
Copy link
Collaborator

rouille commented Jun 1, 2021

In the release notes, feat: add skeleton for applying temporal mapping to inputs (#56) (@danielolsen) is in the fixes, I believe it shoud be in the feat, no?

The line is a little blurry: that PR does not add any functional code, but it does create a higher-level function to manage lower-level code. I can move that to the features if you want.

As you wish. Just went through the list and noted the feat descriptor

Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@danielolsen danielolsen merged commit fa4cd31 into main Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants