-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: various issues with HIFLD transmission loading/processing #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouille
reviewed
Nov 9, 2021
BainanXia
reviewed
Nov 9, 2021
BainanXia
reviewed
Nov 9, 2021
BainanXia
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
818f7e8
to
d205919
Compare
4 tasks
danielolsen
added a commit
that referenced
this pull request
Dec 8, 2021
…ssion_fixes fix: various issues with HIFLD transmission loading/processing
danielolsen
added a commit
that referenced
this pull request
Jan 5, 2022
…ssion_fixes fix: various issues with HIFLD transmission loading/processing
danielolsen
added a commit
that referenced
this pull request
Jan 8, 2022
…ssion_fixes fix: various issues with HIFLD transmission loading/processing
danielolsen
added a commit
that referenced
this pull request
Jan 31, 2022
…ssion_fixes fix: various issues with HIFLD transmission loading/processing
danielolsen
added a commit
that referenced
this pull request
Feb 25, 2022
…ssion_fixes fix: various issues with HIFLD transmission loading/processing
danielolsen
added a commit
that referenced
this pull request
Mar 15, 2022
…ssion_fixes fix: various issues with HIFLD transmission loading/processing
danielolsen
added a commit
that referenced
this pull request
Apr 1, 2022
…ssion_fixes fix: various issues with HIFLD transmission loading/processing
danielolsen
added a commit
that referenced
this pull request
Apr 5, 2022
…ssion_fixes fix: various issues with HIFLD transmission loading/processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Various fixes for processing of HIFLD transmission data:
IN SERVICE
, also return lines whose status isNOT AVAILABLE
, since this represents most of the lines in the Rocky Mountain states (see Improve handling of DC lines when loading HIFLD data #233 (comment)).What the code is doing
IN SERVICE
andNOT AVAILABLE
lines.map_lines_to_substations_using_coords
, we fix a lat/lon vs. lon/lat bug.filter_islands_and_connect_with_mst
, we add a meaningful index to the new lines.build_transmission
, we add a meaningful index to the new transformers.test_map_lines_to_substations_using_coords
) that catches the lat/lon vs. lon/lat issue as well as tests the combining of substations via coordinate rounding.Testing
The new unit test initially fails due to the lat/lon issue, but passes once the fix is added.
Usage Example/Visuals
Before:
After:
After the changes, we have many more branches, and no duplicate indices.
Time estimate
30 minutes.