Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are very slow due to big file downloads #145

Closed
danielolsen opened this issue Feb 16, 2021 · 1 comment · Fixed by #148
Closed

Tests are very slow due to big file downloads #145

danielolsen opened this issue Feb 16, 2021 · 1 comment · Fixed by #148
Assignees

Comments

@danielolsen
Copy link
Contributor

On a pretty good home internet connection, with nothing else going on:

  • prereise/gather/demanddata/nrel_efs/tests/test_get_efs_data.py::test_download_flexibility_data takes >2 minutes
  • prereise/gather/demanddata/nrel_efs/tests/test_get_efs_data.py::test_download_demand_data takes >1 minute
  • no other tests take more than 10 seconds

Can we cut this time down somehow, perhaps by testing the download functionality on smaller files?

@lanesmith
Copy link
Collaborator

Yeah, the files are pretty large so downloading and extracting takes a while. I could write tests for the private functions (e.g., _download_data, _extract_data) instead. This should allow us to test the functionality on smaller files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants