Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pyproj requirement from 1.9.6 #144

Closed
danielolsen opened this issue Feb 16, 2021 · 1 comment · Fixed by #147
Closed

Upgrade pyproj requirement from 1.9.6 #144

danielolsen opened this issue Feb 16, 2021 · 1 comment · Fixed by #147
Assignees

Comments

@danielolsen
Copy link
Contributor

pyproj v1.9.6 is only compatible with Python 3.7 and lower. (see https://pyproj4.github.io/pyproj/stable/history.html#id20)

We want to be able to run with Python 3.8 and above, so we need to upgrade to at least pyproj 2.x, if not the new 3.0.

Looking at wheat we did in PostREISE (Breakthrough-Energy/PostREISE#154), there's not a perfect 1:1 translation to our usage here, since PostREISE had projections based on EPSG reference systems, while we've got a projection based on a PROJ string. It seems like using these strings, rather than an EPSG or similar, is gently advised-against (see https://proj.org/faq.html#what-is-the-best-format-for-describing-coordinate-reference-systems), so if it's easy to use an EPSG reference system then maybe we can kill two birds with one stone.

@danielolsen danielolsen changed the title Upgrade require pyproj from 1.9.6 Upgrade pyproj requirement from 1.9.6 Feb 16, 2021
@danielolsen
Copy link
Contributor Author

Somehow, the CI tests on the server have no problem with the current lockfile (using Python 3.8.7).

Running Python 3.8.3 locally on Windows, I get an error trying to pipenv sync or pipenv sync --pre using the current develop. I created a branch that can be used in the meantime (daniel/no_pyproj) via:

pipenv sync --python 3.7
pipenv uninstall pyproj --skip-lock
pipenv lock --pre

This branch will pipenv sync and all `python -m pytest -m "not integration" works successfully using Python 3.8.3 on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants